APPSINTG-160:GCP integration | Cloud Functions Integrations - Documen… - #7041
Open
shreyashnaik-sumo wants to merge 5 commits into
Open
APPSINTG-160:GCP integration | Cloud Functions Integrations - Documen…#7041shreyashnaik-sumo wants to merge 5 commits into
shreyashnaik-sumo wants to merge 5 commits into
Conversation
shreyashnaik-sumo
requested review from
JV0812,
amee-sumo,
kimsauce and
mafsumo
as code owners
August 20, 2026 12:43
kimsauce
reviewed
Aug 21, 2026
kimsauce
approved these changes
Aug 21, 2026
kimsauce
reviewed
Aug 24, 2026
kimsauce
left a comment
kimsauce
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the new Google Cloud Functions integration doc. CI is green (spellcheck/build/merge-window all pass), and most of the content correctly follows this directory's established patterns (reused Google Chat/Drive screenshots for generic GCP Console steps, misc/<slug>-configuration.png image path, Version/Updated block, Change Log format). Left inline comments on a few things worth addressing before merge:
- Frontmatter deviates from the directory-wide convention (
id+ non-emptydescriptionwhere every neighboring doc uses neither). - Possible copy-paste residue in the WIF role/Lambda names — worth confirming with the backend owner that Cloud Functions actually shares Cloud Run's
gcpiamrole rather than having its own. - Missing permission in the least-privilege custom role list for the documented "Monitor Function Logs" action.
- Minor: action name phrasing nit.
Nothing here blocks CI, but items 2 and 3 are functional/accuracy concerns worth confirming before publishing.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Google Cloud Functions integration (implemented via Cloud Run v2 service APIs that back 2nd-gen functions) and adds several actions plus accompanying pytest coverage.
Changes:
Adds the Google Cloud Functions integration definition with test-connection code and configuration fields for Secret (service account) and IAM/WIF authentication.
Implements actions to list/get services, trigger a service URL, monitor logs, and manage IAM policy / invoker access on the underlying Cloud Run service.
Select the type of change
Ticket (if applicable)
https://sumologic.atlassian.net/browse/APPSINTG-160